Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gflags: fix static musl build #76833

Closed
wants to merge 1 commit into from
Closed

gflags: fix static musl build #76833

wants to merge 1 commit into from

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@veprbl veprbl mentioned this pull request Jan 2, 2020
3 of 10 tasks complete
@veprbl
veprbl approved these changes Jan 2, 2020
Copy link
Member

@veprbl veprbl left a comment

[nix-shell:~/.cache/nixpkgs-review/pr-76833/nixpkgs]$ ls -1 $(nix-build . -A gflags)/lib
cmake
libgflags.a
libgflags_nothreads.a
libgflags_nothreads.so
libgflags_nothreads.so.2.2
libgflags_nothreads.so.2.2.2
libgflags.so
libgflags.so.2.2
libgflags.so.2.2.2
pkgconfig

[nix-shell:~/.cache/nixpkgs-review/pr-76833/nixpkgs]$ ls -1 $(nix-build . -A pkgsStatic.gflags)/lib
cmake
libgflags.a
libgflags_nothreads.a
pkgconfig
@FRidh
Copy link
Member Author

@FRidh FRidh commented Jan 3, 2020

merged 93da24c instead

@FRidh FRidh closed this Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.