Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl::TimeDate: fixed TimeDate's getdate tests #76840

Closed

Conversation

@urbas
Copy link

@urbas urbas commented Jan 2, 2020

Motivation for this change

TimeDate's getdate tests use the short notation YY as the time offset. This incorrectly uses 2070 (instead of 1970) and because of this tests fail.

Things done

This change fixes tests by using YYYY notation instead.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra

TimeDate's getdate tests use the short notation YY as the time offset. This incorrectly uses 2070 (instead of 1970) and because of this tests fail.

This change fixes tests by using YYYY notation instead.
@urbas
Copy link
Author

@urbas urbas commented Jan 2, 2020

Closing in favour of PR #76810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.