Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/apropos: init #76841

Closed
wants to merge 1 commit into from
Closed

nixos/apropos: init #76841

wants to merge 1 commit into from

Conversation

@matthewbauer
Copy link
Member

matthewbauer commented Jan 2, 2020

Fixes #14472

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Fixes #14472
systemd.tmpfiles.rules = [ "d /var/cache/man 0755 root root -" ];

system.activationScripts.apropos = ''
${pkgs.mandb}/bin/mandb

This comment has been minimized.

Copy link
@Infinisil

Infinisil Jan 2, 2020

Member

Can we do this at build-time instead? Would be much cleaner. This here will run on every boot and rebuild.

This comment has been minimized.

Copy link
@rnhmjoj

rnhmjoj Apr 10, 2020

Contributor

@matthewbauer are you still interested in this PR? If not I'm ok taking over this task.

This comment has been minimized.

Copy link
@DamienCassou

DamienCassou Apr 27, 2020

Contributor

@rnhmjoj can you please have a look? It would be great to fix this old issue. Thank you.

{

options.documentation.apropos = {
enable = mkOption {

This comment has been minimized.

Copy link
@Infinisil

Infinisil Jan 2, 2020

Member

I think this whole config can be moved to documentation.nix under the mkIf cfg.man.enable without an additional .enable option if it can be done at build time.

@matthewbauer
Copy link
Member Author

matthewbauer commented May 9, 2020

Closing in favor of #86489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.