Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os-prober: add missing dmraid, lvm2 dependencies #76843

Merged
merged 2 commits into from Feb 2, 2020

Conversation

@jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Jan 2, 2020

Motivation for this change

Otherwise, os-prober may fail to see LVM and RAID partitions.

Note

One might want to add dmraid as well, but I don't know if this is actually necessary. This has been done.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: Ubuntu
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • adds 8 213 688 bytes (8 MiB) to os-prober
    • adds 256 bytes (0.25 kiB) to /run/current-system
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @symphorien

Otherwise, os-prober may fail to see LVM partitions.
@symphorien
Copy link
Contributor

@symphorien symphorien commented Jan 2, 2020

Thanks!
Can you also add dmraid as you mentionned ?
Grepping "if type" in os-prober suggests we could also add lsblk.
I don't know where log-output comes from, and it looks non-essential.

For people missing context:
Fixes #76690

If this is not done, dmraid is likely to not find OSes on RAID.
@jakobrs
Copy link
Contributor Author

@jakobrs jakobrs commented Jan 3, 2020

I've added dmraid. lsblk is already added by libuuid. The only commands that aren't in the program's PATH currently are log-output and anna-install.

Edit: Should I maybe add util-linux as well? Because it appears that lsblk, while being exported by libuuid, "belongs to" util-linux (with libuuid being a subproject of util-linux).

@jakobrs jakobrs changed the title os-prober: add missing lvm2 dependency os-prober: add missing dmraid, lvm2 dependencies Jan 3, 2020
Copy link
Contributor

@symphorien symphorien left a comment

Thanks!

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 1, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/89

@worldofpeace worldofpeace merged commit edbf5d8 into NixOS:master Feb 2, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
os-prober on aarch64-linux Success
Details
os-prober on x86_64-linux Success
Details
anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
os-prober: add missing dmraid, lvm2 dependencies
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 2, 2020
os-prober: add missing dmraid, lvm2 dependencies
(cherry picked from commit edbf5d8)
@jakobrs jakobrs deleted the jakobrs:os-prober-dep branch Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.