Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-plugins: hashivim/vim-terraform: fix the filetypedetect autocmd #76845

Merged
merged 1 commit into from Jan 4, 2020

Conversation

@kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 2, 2020

Motivation for this change

I'm using this plugin, and I keep getting the following error at Vim startup

Error detected while processing /nix/store/37njws9gkfz3w5q1mm9kf3fcbd58lwqs-vimplugin-vim-terraform-2019-12-16/share/vim-plugins/vim-terraform/ftdetect/terraform.vim:                                                                                                           
line    2:                                                                                                                                                                                                                                                                       
E216: No such group or event: filetypedetect BufRead,BufNewFile *.tf

This issue used to block Vim's manifest generation, but that got fixed in #66536. That fix was a workaround though, this should fix that as well as Vim's startup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@kalbasit
Copy link
Member Author

@kalbasit kalbasit commented Jan 4, 2020

Tested locally with kalbasit/shabka@d2bb48c. Merging...

@kalbasit kalbasit merged commit fa92f00 into NixOS:master Jan 4, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@kalbasit kalbasit deleted the kalbasit:vim-terraform_fix-autocmd branch Jan 4, 2020
kalbasit added a commit to kalbasit/nixpkgs that referenced this pull request Jan 4, 2020
…ixOS#76845)

(cherry picked from commit fa92f00)
kalbasit added a commit that referenced this pull request Jan 4, 2020
…76845) (#76950)

(cherry picked from commit fa92f00)
kalbasit added a commit to kalbasit/nixpkgs that referenced this pull request Jan 6, 2020
…utocmd (NixOS#76845)"

This reverts commit fa92f00.
jonringer added a commit that referenced this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.