Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gegl: remove flaky test #76846

Merged
merged 1 commit into from Jan 2, 2020
Merged

gegl: remove flaky test #76846

merged 1 commit into from Jan 2, 2020

Conversation

@lovesegfault
Copy link
Contributor

@lovesegfault lovesegfault commented Jan 2, 2020

Motivation for this change

Following #75773 this adds to the Debian patch with our own that removes the flaky backend-file test. This should allow for a new nixos-unstable release, since trunk-combined/tested has been failing for days due to this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @jtojnar

@lovesegfault lovesegfault force-pushed the lovesegfault:gegl-no-flaky-tests branch from a78062b to be12549 Jan 2, 2020
@lovesegfault lovesegfault changed the title gegl: remove flaky tests gegl: remove flaky test Jan 2, 2020
@lovesegfault lovesegfault requested a review from grahamc Jan 2, 2020
@lovesegfault lovesegfault force-pushed the lovesegfault:gegl-no-flaky-tests branch from be12549 to af29265 Jan 2, 2020
@ofborg ofborg bot requested a review from jtojnar Jan 2, 2020
@grahamc
Copy link
Member

@grahamc grahamc commented Jan 2, 2020

@GrahamcOfBorg build gegl_0_4

@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Jan 2, 2020

[16 built, 473 copied (2230.8 MiB), 624.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76846
14 package built:
gegl_0_4 gimp gimp-with-plugins gimpPlugins.fourier gimpPlugins.gap gimpPlugins.gimplensfun gimpPlugins.gmic gimpPlugins.lightning gimpPlugins.lqrPlugin gimpPlugins.resynthesizer gimpPlugins.ufraw gimpPlugins.waveletSharpen gnome-photos ufraw
@grahamc grahamc merged commit 45a1974 into NixOS:master Jan 2, 2020
19 checks passed
19 checks passed
gegl on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
gegl on x86_64-darwin Success
Details
gegl on x86_64-linux Success
Details
gegl_0_4 on aarch64-linux Success
Details
gegl_0_4 on x86_64-darwin Success
Details
gegl_0_4 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lovesegfault lovesegfault deleted the lovesegfault:gegl-no-flaky-tests branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.