Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny: init at 0.5.1 #76868

Merged
merged 1 commit into from Jan 16, 2020
Merged

tiny: init at 0.5.1 #76868

merged 1 commit into from Jan 16, 2020

Conversation

@Br1ght0ne
Copy link
Contributor

@Br1ght0ne Br1ght0ne commented Jan 3, 2020

Motivation for this change

Closes #76848 and closes osa1/tiny#166.

https://github.com/osa1/tiny/releases/tag/0.5.0

Things that need to be resolved
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Br1ght0ne
Copy link
Contributor Author

@Br1ght0ne Br1ght0ne commented Jan 3, 2020

Thanks @multun!

@multun
Copy link
Member

@multun multun commented Jan 3, 2020

the build doesn't work for me:

builder for '/nix/store/ax1wxqrcdkyivg946rp4y8n2pifp1717-tiny-0.5.0-vendor.drv' failed with exit code 1; last 10 log lines:
  unpacking source archive /nix/store/7yw0hg7xxqcxid4qbdfjs00bn7304lz0-source
  source root is source
  patching sources
  installing
  
  ERROR: The Cargo.lock file doesn't exist
  
  Cargo.lock is needed to make sure that cargoSha256 doesn't change
  when the registry is updated.
@Br1ght0ne
Copy link
Contributor Author

@Br1ght0ne Br1ght0ne commented Jan 3, 2020

@multun As it should, see osa1/tiny@b309d1a and osa1/tiny#166 (comment). This commit was made after the 0.5.0 release, and so we need a new release to be published.

@multun
Copy link
Member

@multun multun commented Jan 3, 2020

Ooooh yeah my bad. Let's wait a bit then, thanks for your work!

@Br1ght0ne Br1ght0ne force-pushed the Br1ght0ne:tiny-0.5.0 branch from f279300 to cb132f9 Jan 8, 2020
@Br1ght0ne Br1ght0ne marked this pull request as ready for review Jan 8, 2020
@Br1ght0ne Br1ght0ne requested a review from multun Jan 8, 2020
@Br1ght0ne
Copy link
Contributor Author

@Br1ght0ne Br1ght0ne commented Jan 9, 2020

@dywedir The upstream fix is included now.

@multun
multun approved these changes Jan 9, 2020
Copy link
Member

@multun multun left a comment

LGTM

@Br1ght0ne Br1ght0ne changed the title tiny: init at 0.5.0 tiny: init at 0.5.1 Jan 16, 2020
@Br1ght0ne
Copy link
Contributor Author

@Br1ght0ne Br1ght0ne commented Jan 16, 2020

cc @marsam for merging. Thanks!

@marsam marsam merged commit 33941e4 into NixOS:master Jan 16, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tiny on aarch64-linux Success
Details
tiny on x86_64-linux Success
Details
@marsam
Copy link
Contributor

@marsam marsam commented Jan 16, 2020

Thanks!

@Br1ght0ne Br1ght0ne deleted the Br1ght0ne:tiny-0.5.0 branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.