Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: keep using gcc8 to work-around failing rpi build #76880

Closed
wants to merge 1 commit into from
Closed

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 3, 2020

Unless anyone knows how to solve this, keep using gcc8.

https://hydra.nixos.org/build/109284638

In file included from <command-line>:
./../include/libc-symbols.h:471:26: error: '__EI___errno_location'
specifies less restrictive attributes than its target
'__errno_location': 'const', 'nothrow' [-Werror=missing-attributes]
  471 |   extern __typeof (name) __EI_##name \
      |                          ^~~~~
./../include/libc-symbols.h:475:29: note: in expansion of macro
'__hidden_ver1'
475 | #  define hidden_def(name)  __hidden_ver1(__GI_##name, name,
name);
      |                             ^~~~~~~~~~~~~
./../include/libc-symbols.h:539:32: note: in expansion of macro
'hidden_def'
  539 | # define libc_hidden_def(name) hidden_def (name)
      |                                ^~~~~~~~~~
errno-loc.c:28:1: note: in expansion of macro 'libc_hidden_def'
   28 | libc_hidden_def (__errno_location)
      | ^~~~~~~~~~~~~~~
errno-loc.c:24:1: note: '__EI___errno_location' target declared here
   24 | __errno_location (void)
      | ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [../o-iterator.mk:9: /build/build/csu/errno-loc.os] Error 1
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

https://hydra.nixos.org/build/109284638

```
In file included from <command-line>:
./../include/libc-symbols.h:471:26: error: '__EI___errno_location'
specifies less restrictive attributes than its target
'__errno_location': 'const', 'nothrow' [-Werror=missing-attributes]
  471 |   extern __typeof (name) __EI_##name \
      |                          ^~~~~
./../include/libc-symbols.h:475:29: note: in expansion of macro
'__hidden_ver1'
475 | #  define hidden_def(name)  __hidden_ver1(__GI_##name, name,
name);
      |                             ^~~~~~~~~~~~~
./../include/libc-symbols.h:539:32: note: in expansion of macro
'hidden_def'
  539 | # define libc_hidden_def(name) hidden_def (name)
      |                                ^~~~~~~~~~
errno-loc.c:28:1: note: in expansion of macro 'libc_hidden_def'
   28 | libc_hidden_def (__errno_location)
      | ^~~~~~~~~~~~~~~
errno-loc.c:24:1: note: '__EI___errno_location' target declared here
   24 | __errno_location (void)
      | ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [../o-iterator.mk:9: /build/build/csu/errno-loc.os] Error 1
```
@FRidh
Copy link
Member Author

@FRidh FRidh commented Jan 5, 2020

alternative #76972

@flokli
Copy link
Contributor

@flokli flokli commented Jan 11, 2020

I'd prefer #76972.

@flokli
Copy link
Contributor

@flokli flokli commented Jan 11, 2020

#76972 was merged - closing.

@flokli flokli closed this Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.