Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #75031 - caused 2 hydra failures #76881

Closed
wants to merge 7 commits into from
Closed

Conversation

@grahamc
Copy link
Member

@grahamc grahamc commented Jan 3, 2020

#75031 caused a few hydra failures -- first some IFD due to some path confusion, then due to nixpkgs.tarball failure. Reverting until we can test it a bit more carefully :)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

grahamc added 7 commits Jan 3, 2020
…yntax"

This reverts commit aa61342.

See #75031
This reverts commit 3cc77ce.

See #75031
…types.submodule"

This reverts commit 5002e6a.

See #75031
This reverts commit 5414b40.

See #75031
This reverts commit 90c82bf.

See #75031
This reverts commit bc42515.

See #75031
This reverts commit cc81320.

See #75031
@grahamc grahamc requested review from edolstra, Infinisil and nbp as code owners Jan 3, 2020
@grahamc
Copy link
Member Author

@grahamc grahamc commented Jan 3, 2020

Update: validating this PR through a bisection.

@grahamc
Copy link
Member Author

@grahamc grahamc commented Jan 3, 2020

I think I might be mistaken, checking.

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 3, 2020

hydra eval was fixed by an earlier revert. Tarball would be fixed by this PR according to ofborg although it still fails for me.

@grahamc
Copy link
Member Author

@grahamc grahamc commented Jan 3, 2020

Sorry, #75031 wasn't related.

@grahamc grahamc closed this Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.