Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gi-gdkx11: Default to 3.X version #76883

Closed
wants to merge 15 commits into from
Closed

Conversation

@mdorman
Copy link
Contributor

@mdorman mdorman commented Jan 3, 2020

The newer (4.X) versions require gtk4 which shouldn't be the default.

Motivation for this change

Fixes all packages that depend on gi-gdkx11 (which wasn't able to build since gtk4 isn't available in Nix)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

peti and others added 14 commits Dec 28, 2019
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@5ccecb7.
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@bb9a7bf.
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@b56d8e5.
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@5b45257.
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@d07acf4.
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@a306985.
Builds fine now.
haskellPackages.webby: mark unbroken
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@314df3f.
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@2b3fecd.
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@bb864b3.
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Jan 4, 2020

@mdorman Thanks for trying to fix this.

However, the default-package-overrides section is generated semi-automatically and shouldn't be added to by hand.

I just sent a PR adding a comment to try to clarify this. Please feel free to comment on this PR if anything is still unclear: #76912.

As for gi-gdkx11, there isn't a good way to default to an older version of a package that is not on Stackage. I'd urge you to try to get upstream to the package into Stackage so that we don't have to necessarily do anything here in nixpkgs.

If you wanted to explicitly generate an older version of a package, you can add it to this list:

haskellPackages chooses to default to the newer (4.X) gtk4 versions,
even though nix doesn't provide the necessary libraries.

This change makes sure that the gtk3 version of gi-gdkx11 will be
available after the next package update, and provides an override so
that taffybar will use it and thus be compilable.
@mdorman mdorman force-pushed the mdorman:gi-gdkx11 branch from 11bd2cf to d886453 Jan 4, 2020
@peti
Copy link
Member

@peti peti commented Jan 5, 2020

The default-package-overrides section is generated semi-automatically and shouldn't be added to by hand.

Note that you can edit default-package-overrides by hand. The code that generates part of that section from Stackage looks for the comment "# LTS Haskell" and replaces everything that follows it until the end of the section: https://github.com/NixOS/cabal2nix/blob/master/update-stackage.sh#L46-L54.

In other words, if you add manual overrides before that comment, then it should be fine.

@peti peti force-pushed the NixOS:haskell-updates branch 7 times, most recently from 23eb5a9 to 24ebeb9 Jan 5, 2020
@peti peti force-pushed the NixOS:haskell-updates branch from 24ebeb9 to 3ab6627 Jan 5, 2020
@peti peti force-pushed the NixOS:haskell-updates branch 6 times, most recently from 5011d9e to 0685be7 Jan 10, 2020
@peti
Copy link
Member

@peti peti commented Jan 17, 2020

@mdorman, will you update this PR?

@peti peti force-pushed the NixOS:haskell-updates branch 5 times, most recently from b49676d to 6f8c1c9 Jan 17, 2020
@peti
Copy link
Member

@peti peti commented Jan 24, 2020

Please feel free to submit an updated PR when the issues pointed out during review are fixed.

@peti peti closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.