Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frescobaldi: 3.0.0 -> 3.1 #76889

Merged
merged 1 commit into from Jan 3, 2020
Merged

frescobaldi: 3.0.0 -> 3.1 #76889

merged 1 commit into from Jan 3, 2020

Conversation

@puzzlewolf
Copy link
Contributor

@puzzlewolf puzzlewolf commented Jan 3, 2020

Motivation for this change

Closes: #76847

3.0.0 does not work #76847 because it needs wrapQtAppsHook.

Also, version 3.1. is available, which replaces QtWebKit with QtWebEngine #53079.

Things done

I modeled the changes after #66796, which fixed the same problem for anki. That change uses pyqtwebengine, so I decided to move frescobaldi to 3.1.

I do not really understand these lines:

  dontWrapQtApps = true;
  makeWrapperArgs = [
      "\${qtWrapperArgs[@]}"
  ];

Without makeWrapperArgs ..., startup fails with the same error as before,

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""

Without dontWrapQtApps = true, frescobaldi starts. But anki has this line, so, what is it needed for?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sepi

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 3, 2020

please fix the commit title and PR title according the contributing guidelines. Specifically, include the attribute name.

@puzzlewolf puzzlewolf changed the title 3.0.0 -> 3.1 frescobaldi: 3.0.0 -> 3.1 Jan 3, 2020
@puzzlewolf puzzlewolf force-pushed the puzzlewolf:frescobaldi branch from 553d20b to 1fc2ef2 Jan 3, 2020
@puzzlewolf
Copy link
Contributor Author

@puzzlewolf puzzlewolf commented Jan 3, 2020

Whoops, fixed, thanks for the heads-up.

@puzzlewolf puzzlewolf force-pushed the puzzlewolf:frescobaldi branch from 1fc2ef2 to cfa2ceb Jan 3, 2020
@veprbl veprbl mentioned this pull request Jan 3, 2020
19 of 68 tasks complete
@veprbl
veprbl approved these changes Jan 3, 2020
Copy link
Member

@veprbl veprbl left a comment

Runs on NixOS x86_64-linux

@veprbl veprbl merged commit c5e72fa into NixOS:master Jan 3, 2020
@puzzlewolf puzzlewolf deleted the puzzlewolf:frescobaldi branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.