Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: build using gcc8 #76890

Merged
merged 1 commit into from Jan 3, 2020
Merged

nix: build using gcc8 #76890

merged 1 commit into from Jan 3, 2020

Conversation

@LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 3, 2020

Workaround for NixOS/nix#3300.

https://hydra.nixos.org/build/109304568

running tests
checking Nixpkgs on i686-linux
error: stack overflow (possible infinite recursion)
build time elapsed:  0m0.068s 0m0.029s 0m36.549s 0m6.187s
builder for '/nix/store/dr5kd28msqmqk3hkz0ayx10dww6s8dn9-nixpkgs-tarball-20.03pre207974.16c665911fb.drv' failed with exit code 1
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested tarball evaluation nix-build pkgs/top-level/release.nix -A tarball
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra @grahamc

Workaround for NixOS/nix#3300.

https://hydra.nixos.org/build/109304568

    running tests
    checking Nixpkgs on i686-linux
    error: stack overflow (possible infinite recursion)
    build time elapsed:  0m0.068s 0m0.029s 0m36.549s 0m6.187s
    builder for '/nix/store/dr5kd28msqmqk3hkz0ayx10dww6s8dn9-nixpkgs-tarball-20.03pre207974.16c665911fb.drv' failed with exit code 1
@grahamc
Copy link
Member

@grahamc grahamc commented Jan 3, 2020

Testing, but I have to build boost first :|

@ofborg ofborg bot requested a review from edolstra Jan 3, 2020
@grahamc grahamc merged commit e0470e1 into NixOS:master Jan 3, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix on aarch64-linux Success
Details
nix on x86_64-darwin Success
Details
nix on x86_64-linux Success
Details
@LnL7 LnL7 deleted the LnL7:nix-gcc-8 branch Jan 3, 2020
@fpletz
Copy link
Member

@fpletz fpletz commented Jan 3, 2020

Thanks! We didn't catch that one. Though I would prefer to do these overrides only on i686-linux if only that arch is indeed affected.

@LnL7
Copy link
Member Author

@LnL7 LnL7 commented Jan 3, 2020

i686 is just the first platform expressions are evaluated for, the nix-env binary is always x86_64-linux. Running nix-env -qa --drv-path (and presumably other evaluations) with a gcc9 based build should be enough to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.