Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.xmodem: init at 0.4.5 #76924

Merged
merged 2 commits into from Jan 7, 2020
Merged

Conversation

@Emantor
Copy link
Contributor

@Emantor Emantor commented Jan 4, 2020

Motivation for this change

Add the python xmodem module for future modules and applications which depend on it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Emantor Emantor requested review from FRidh and jonringer as code owners Jan 4, 2020
@Emantor Emantor changed the title Pkg/python xmodem pythonPackages.xmodem: init at 0.4.5 Jan 4, 2020
@Emantor Emantor force-pushed the Emantor:pkg/python-xmodem branch 3 times, most recently from 7dd80ba to 868c493 Jan 5, 2020
@Emantor Emantor force-pushed the Emantor:pkg/python-xmodem branch 2 times, most recently from 1d6b95e to 44a86cb Jan 6, 2020
Copy link
Contributor

@jonringer jonringer left a comment

otherwise LGTM

pkgs/development/python-modules/xmodem/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2020

@GrahamcOfBorg build pythonPackages.xmodem python3Packages.xmodem

@Emantor Emantor force-pushed the Emantor:pkg/python-xmodem branch from 44a86cb to b656da1 Jan 6, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2020

@GrahamcOfBorg build pythonPackages.xmodem python3Packages.xmodem

@markuskowa markuskowa merged commit f8193b1 into NixOS:master Jan 7, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python3Packages.xmodem, pythonPackages.xmodem on aarch64-linux Success
Details
python3Packages.xmodem, pythonPackages.xmodem on x86_64-darwin Success
Details
python3Packages.xmodem, pythonPackages.xmodem on x86_64-linux Success
Details
@Emantor Emantor deleted the Emantor:pkg/python-xmodem branch Jan 7, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 7, 2020
pythonPackages.xmodem: init at 0.4.5

(cherry picked from commit f8193b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.