Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_12, go_1_13: skip TestExtraFiles on 32-bit arm #76944

Merged

Conversation

@thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Jan 4, 2020

Motivation for this change

The test is known to be flaky in some environments, and I'm seeing it
consistently in an armv7l-linux vm.

Note that to test this the contents of the following PRs are required:

And it will likely fail to build due to golang/go#32738, which will be fixed in go 1.14.

The patch to disable the test is duplicated to avoid a mass rebuild on other platforms.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (armv7l-linux vm)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: golang label Jan 4, 2020
@thefloweringash thefloweringash force-pushed the thefloweringash:go-flaky-test-extra-files-arm branch from 4aeb516 to be738a0 Jan 4, 2020
@thefloweringash thefloweringash changed the title go_1_13: skip TestExtraFiles on 32-bit arm go_1_12, go_1_13: skip TestExtraFiles on 32-bit arm Jan 4, 2020
@ofborg ofborg bot requested review from cstrahan, kalbasit, velovix and Mic92 Jan 4, 2020
The test is known to be flaky in some environments, and I'm seeing it
consistently in an armv7l-linux vm.
@thefloweringash thefloweringash force-pushed the thefloweringash:go-flaky-test-extra-files-arm branch from be738a0 to 6657ec8 Jan 4, 2020
@thefloweringash thefloweringash marked this pull request as ready for review Jan 4, 2020
@kalbasit kalbasit merged commit ffd68f2 into NixOS:master Jan 10, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
go_1_12, go_1_13 on aarch64-linux Success
Details
go_1_12, go_1_13 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@kalbasit kalbasit mentioned this pull request Jan 10, 2020
4 of 10 tasks complete
@thefloweringash thefloweringash deleted the thefloweringash:go-flaky-test-extra-files-arm branch Jan 10, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
The test is known to be flaky in some environments, and I'm seeing it
consistently in an armv7l-linux vm.

(cherry picked from commit ffd68f2)
Frostman added a commit to Frostman/nixpkgs that referenced this pull request Feb 8, 2020
The test is known to be flaky in some environments, and I'm seeing it
consistently in an armv7l-linux vm.

(cherry picked from commit ffd68f2)
pull bot added a commit to Frostman/nixpkgs that referenced this pull request Feb 12, 2020
The test is known to be flaky in some environments, and I'm seeing it
consistently in an armv7l-linux vm.

(cherry picked from commit ffd68f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.