Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.tensorflow: fix build with cudatoolkit 10.2 #76945

merged 1 commit into from Jan 6, 2020


Copy link

@prusnak prusnak commented Jan 4, 2020

Motivation for this change

This fixes the tensorflow package build failure.

Before the change the build with cudatoolkit 10.2 (now default) fails with the following error:

ERROR: /build/output/external/nccl_archive/BUILD.bazel:53:1: fatbinary external/nccl_archive/device_dlink_hdrs.fatbin failed (Exit 1)
fatbinary fatal   : Unknown option '-bin2c-path'

As tensorflow/tensorflow#34429 suggests, the fix is to drop the option from the build_defs.bzl.tpl script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @timokau

Copy link

@timokau timokau left a comment

Please add a link to the upstream issue as a comment where you include the patch.

@prusnak prusnak force-pushed the prusnak:tensorflow-drop-bin2c-path branch from 08181e4 to 9a982d3 Jan 6, 2020
@prusnak prusnak requested a review from timokau Jan 6, 2020
timokau approved these changes Jan 6, 2020
Copy link

@timokau timokau commented Jan 6, 2020

Thank you!

@timokau timokau merged commit bdbec90 into NixOS:master Jan 6, 2020
@prusnak prusnak deleted the prusnak:tensorflow-drop-bin2c-path branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.