Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several python packages #76954

Merged
merged 10 commits into from Jan 6, 2020
Merged

Conversation

@kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 4, 2020

Motivation for this change

Extracting the new packages from the outdated #64962, and replaces #76952.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@kalbasit kalbasit requested review from FRidh and jonringer as code owners Jan 4, 2020
@kalbasit kalbasit force-pushed the kalbasit:nixpkgs_add-python-packages branch from 2ddeb6d to e7c9f8a Jan 4, 2020
@kalbasit
Copy link
Member Author

@kalbasit kalbasit commented Jan 4, 2020

@GrahamcOfBorg build h3 python2Packages.h3 python2Packages.timezonefinder python2Packages.snowflake-sqlalchemy python2Packages.snowflake-connector-python python2Packages.oscrypto python2Packages.area python3Packages.h3 python3Packages.timezonefinder python3Packages.snowflake-sqlalchemy python3Packages.snowflake-connector-python python3Packages.oscrypto python3Packages.area

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2020

please resolve conflicts

kalbasit and others added 9 commits Jul 16, 2019
Disable linting as it uses clang-tidy, which isn't a cc-wrapper and
won't find our dependencies automatically.
@kalbasit kalbasit force-pushed the kalbasit:nixpkgs_add-python-packages branch from e7c9f8a to d6977c0 Jan 6, 2020
@kalbasit
Copy link
Member Author

@kalbasit kalbasit commented Jan 6, 2020

@GrahamcOfBorg build h3
@GrahamcOfBorg build python2Packages.h3 python2Packages.timezonefinder python2Packages.snowflake-sqlalchemy python2Packages.snowflake-connector-python python2Packages.oscrypto python2Packages.area
@GrahamcOfBorg build python3Packages.h3 python3Packages.timezonefinder python3Packages.snowflake-sqlalchemy python3Packages.snowflake-connector-python python3Packages.oscrypto python3Packages.area

@kalbasit
Copy link
Member Author

@kalbasit kalbasit commented Jan 6, 2020

@GrahamcOfBorg build h3
@GrahamcOfBorg build python2Packages.h3 python2Packages.timezonefinder python2Packages.snowflake-sqlalchemy python2Packages.snowflake-connector-python python2Packages.oscrypto python2Packages.area
@GrahamcOfBorg build python3Packages.h3 python3Packages.timezonefinder python3Packages.snowflake-sqlalchemy python3Packages.snowflake-connector-python python3Packages.oscrypto python3Packages.area

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM (although I would prefer some more tests)
commits LGTM

[27 built, 136 copied (719.3 MiB), 119.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76954
18 package were built:
h3 python27Packages.area python27Packages.h3 python27Packages.oscrypto python27Packages.snowflake-connector-python python27Packages.snowflake-sqlalchemy python37Packages.area python37Packages.h3 python37Packages.oscrypto python37Packages.snowflake-connector-python python37Packages.snowflake-sqlalchemy python37Packages.timezonefinder python38Packages.area python38Packages.h3 python38Packages.oscrypto python38Packages.snowflake-connector-python python38Packages.snowflake-sqlalchemy python38Packages.timezonefinder
@jonringer jonringer merged commit 0e4457c into NixOS:master Jan 6, 2020
9 checks passed
9 checks passed
python2Packages.area, python2Packages.h3, python2Packages.oscrypto, python2Packages.snowflake-connector-python, python2Packages.snowflake-sqlalchemy, python2Packages.timezonefinder on x86_64-darwin Failure
Details
h3 on aarch64-linux Success
Details
h3 on x86_64-darwin Success
Details
h3 on x86_64-linux Success
Details
python2Packages.area, python2Packages.h3, python2Packages.oscrypto, python2Packages.snowflake-connector-python, python2Packages.snowflake-sqlalchemy, python2Packages.timezonefinder on aarch64-linux Success
Details
python2Packages.area, python2Packages.h3, python2Packages.oscrypto, python2Packages.snowflake-connector-python, python2Packages.snowflake-sqlalchemy, python2Packages.timezonefinder on x86_64-linux Success
Details
python3Packages.area, python3Packages.h3, python3Packages.oscrypto, python3Packages.snowflake-connector-python, python3Packages.snowflake-sqlalchemy, python3Packages.timezonefinder on aarch64-linux Success
Details
python3Packages.area, python3Packages.h3, python3Packages.oscrypto, python3Packages.snowflake-connector-python, python3Packages.snowflake-sqlalchemy, python3Packages.timezonefinder on x86_64-darwin Success
Details
python3Packages.area, python3Packages.h3, python3Packages.oscrypto, python3Packages.snowflake-connector-python, python3Packages.snowflake-sqlalchemy, python3Packages.timezonefinder on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.