Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idris2: init at 0.0.0 (bf5b229) #76971

Closed
wants to merge 3 commits into from
Closed

idris2: init at 0.0.0 (bf5b229) #76971

wants to merge 3 commits into from

Conversation

@lodi
Copy link
Contributor

@lodi lodi commented Jan 5, 2020

Motivation for this change

Added Idris2 compiler.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@tobim tobim left a comment

Builds and installs fine locally.

It might be a good idea to add this to idrisPackages set.

Related: #71125

sha256 = "1ixmdy4zbllmpwmvmmqv1rj9a2y243pggf42pdqkvrkjw50zqlyj";
};

version = "0.0.0";

This comment has been minimized.

@tobim

tobim Jan 7, 2020
Contributor

Nixpkgs typically uses the YYYY-MM-DD schema for untagged sources.

This comment has been minimized.

@lodi

lodi Jan 16, 2020
Author Contributor

Ok, updated to date-based version format.

, idris, chez, racket, chickenPkgs
}:

stdenv.mkDerivation rec {

This comment has been minimized.

@tobim

tobim Jan 7, 2020
Contributor

Is there a specific reason you did not use the build-idris-package function here?

This comment has been minimized.

@lodi

lodi Jan 16, 2020
Author Contributor

I wasn't sure how to make this work with build-idris-package. E.g. idris2 tests are in their own ipkg called from the makefile; buildInputs might be set incorrectly (idris should only be a nativeBuildInput for idris2 I think?); etc.

@locallycompact
Copy link
Contributor

@locallycompact locallycompact commented Apr 15, 2020

Hi is this still active? Idris 2 has just released a v0.1.0.

https://www.idris-lang.org/idris-2-version-010-released.html

I can pick this up.

@lodi
Copy link
Contributor Author

@lodi lodi commented Apr 18, 2020

Sorry for the delay @locallycompact. I updated the PR to track the latest Idris2 git rev.

I think this PR was never merged because it doesn't integrate with the existing idris-packages infrastructure. I'm not too familiar with how idris-packages works so this PR kind of stalled out. If you can get this accepted to nixpkgs in one way or another that'd be great!

@locallycompact
Copy link
Contributor

@locallycompact locallycompact commented Apr 19, 2020

@lodi Hi, thanks for updating this.

I guess then, anybody watching, what are the criteria for integrating it with idris-packages?

How does say python2 and python3 handle this?

@fabianhjr fabianhjr mentioned this pull request May 25, 2020
4 of 10 tasks complete
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented May 25, 2020

Is there anything in this PR that we don't have in #88645 ?

@lodi
Copy link
Contributor Author

@lodi lodi commented May 25, 2020

Nothing major no; just some minor difference to support Chicken Scheme and run tests at build time. I'll close this PR and contribute to #88645 instead.

@lodi lodi closed this May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.