Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicity: 0.7.19 -> 0.8.10, use python3 #76988

Merged
merged 1 commit into from Feb 11, 2020
Merged

duplicity: 0.7.19 -> 0.8.10, use python3 #76988

merged 1 commit into from Feb 11, 2020

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jan 6, 2020

Note that 0.8 is still a dev version.

@Frostman
Copy link
Member

@Frostman Frostman commented Feb 8, 2020

There is 0.8.10 was released January 23, 2020 and it's considered as current stable per https://www.nongnu.org/duplicity

@jtojnar jtojnar added this to the 20.03 milestone Feb 8, 2020
@jtojnar jtojnar self-assigned this Feb 10, 2020
Update, port to Python 3 and clean up.

Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
Co-Authored-By: Frederik Rietdijk <fridh@fridh.nl>
@jtojnar jtojnar force-pushed the FRidh:duplicity branch from f76ca79 to b512693 Feb 10, 2020
Copy link
Contributor

@jtojnar jtojnar left a comment

Verified duplicity working in deja-dup.

@FRidh FRidh changed the title WIP: duplicity: 0.7.19 -> 0.8.08, use python3 duplicity: 0.7.19 -> 0.8.10, use python3 Feb 10, 2020
Copy link
Member Author

@FRidh FRidh left a comment

Change looks good to me, but I haven't tested it.

@jtojnar jtojnar removed this from the 20.03 milestone Feb 10, 2020
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 10, 2020

Let’s merge this after the branch-off, then.

@FRidh
Copy link
Member Author

@FRidh FRidh commented Feb 10, 2020

This may also need a release note considering the potential risk.

@jtojnar jtojnar removed their assignment Feb 10, 2020
@jtojnar jtojnar merged commit c3a6844 into NixOS:master Feb 11, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Python 2 deprecation automation moved this from WIP to Done Feb 11, 2020
@jtojnar jtojnar mentioned this pull request Feb 11, 2020
6 of 10 tasks complete
@FRidh FRidh deleted the FRidh:duplicity branch Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.