Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svxlink: init at 19.09.1 #76990

Merged
merged 1 commit into from Jan 18, 2020
Merged

svxlink: init at 19.09.1 #76990

merged 1 commit into from Jan 18, 2020

Conversation

@zaninime
Copy link
Contributor

@zaninime zaninime commented Jan 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers
@zaninime
Copy link
Contributor Author

@zaninime zaninime commented Jan 13, 2020

@rnhmjoj could you have a look on this one too? Thanks. It's pretty trivial.

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 13, 2020

I can confirm it builds and everything in /bin runs.
Qtel is properly wrapped but so are all other tools. Is this necessary? I think that only Qtel is a Qt application. In that case you should disable the hook and manually wrap Qtel. See for example arx-liberatis package if you don't know how.

Also I noticed is this error when running bin/svxlink

TclVoiceMail: *** ERROR: The spool directory (/nix/store/p0csgl15hlgamcwqw3cinqbjafhm4wnq-svxlink-19.09.1/var/spool/svxlink/voice_mail) is not writable by the current user or does not exist.

I'm not sure whether it can be ignored (because I haven't configured it) or the software needs some patching to change this path.

@zaninime zaninime force-pushed the zaninime:svxlink branch from f564048 to a44586b Jan 14, 2020
@zaninime
Copy link
Contributor Author

@zaninime zaninime commented Jan 14, 2020

@rnhmjoj Thanks a lot for your review. I missed both things actually. Now I fixed it so it's only wrapping qtel and not the rest. The spool dir error can be ignored as that is taken from the default configuration file, so it's possible to configure it (and to configure the location of the config file) at runtime.

Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Ok, it looks all right to me, now.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Jan 14, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/82

@bennofs bennofs merged commit 2e2cb28 into NixOS:master Jan 18, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
svxlink on aarch64-linux Success
Details
svxlink on x86_64-linux Success
Details
@zaninime zaninime deleted the zaninime:svxlink branch Jan 19, 2020
Profpatsch added a commit to Profpatsch/nixpkgs that referenced this pull request Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.