Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scikit-build by removing no longer needed patch. #76993

Merged
merged 1 commit into from Jan 5, 2020

Conversation

@mildlyincompetent
Copy link
Contributor

@mildlyincompetent mildlyincompetent commented Jan 5, 2020

Motivation for this change

scikit-build is currently broken, as it attempts to apply a patch which was relevant for older version but is no longer required for 0.10.0.

Things done

Removed the no longer necessary patch, the failure of which was preventing the package from being built. The package now builds and does not fail any tests.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FlorianFranzen

@mildlyincompetent mildlyincompetent changed the title Remove no longer needed patch. Fix scikit-build by removing no longer needed patch. Jan 5, 2020
@mildlyincompetent
Copy link
Contributor Author

@mildlyincompetent mildlyincompetent commented Jan 5, 2020

@GrahamcOfBorg build python37Packages.scikit-build python27Packages.scikit-build

@mildlyincompetent
Copy link
Contributor Author

@mildlyincompetent mildlyincompetent commented Jan 5, 2020

@GrahamcOfBorg build python37Packages.scikit-build

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 5, 2020

@GrahamcOfBorg build python38Packages.scikit-build

@FlorianFranzen
Copy link
Contributor

@FlorianFranzen FlorianFranzen commented Jan 5, 2020

@mildlyincompetent You are correct. I upstreamed the patch (scikit-build/scikit-build#385) and it was included in the release 0.9.0, so it is no longer needed. Thank you for fixing this.

@roberth roberth merged commit 0752cf0 into NixOS:master Jan 5, 2020
20 checks passed
20 checks passed
python27Packages.scikit-build, python37Packages.scikit-build on aarch64-linux Failure
Details
python37Packages.scikit-build on aarch64-linux Failure
Details
python38Packages.scikit-build on aarch64-linux Failure
Details
python38Packages.scikit-build on x86_64-darwin Failure
Details
python38Packages.scikit-build on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.scikit-build, python37Packages.scikit-build on x86_64-linux Success
Details
python37Packages.scikit-build on x86_64-linux Success
Details
@mildlyincompetent mildlyincompetent deleted the mildlyincompetent:fix-scikit-build branch Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.