Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.skorch: init at 0.8.0 #76997

Merged
merged 1 commit into from May 26, 2020
Merged

python3Packages.skorch: init at 0.8.0 #76997

merged 1 commit into from May 26, 2020

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • [NA] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bcdarwin bcdarwin requested review from FRidh and jonringer as code owners Jan 5, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:skorch branch from ea149c6 to 459c8c0 Jan 5, 2020
@bcdarwin bcdarwin changed the title skorch: init at 0.7.0 pythonPackages.skorch: init at 0.7.0 Jan 5, 2020
@bcdarwin bcdarwin changed the title pythonPackages.skorch: init at 0.7.0 python3Packages.skorch: init at 0.7.0 Jan 5, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:skorch branch from 459c8c0 to dc18038 Jan 5, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:skorch branch 2 times, most recently from 5b9ff7f to d5256ba Jan 5, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:skorch branch from d5256ba to 18c4f2a Jan 6, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:skorch branch from 18c4f2a to d0ae583 Jan 6, 2020
@FRidh
Copy link
Member

@FRidh FRidh commented Jan 6, 2020

@GrahamcOfBorg build python27Packages.skorch python37Packages.skorch python38Packages.skorch

@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented Jan 7, 2020

Nothing with a Pytorch dependency (even without CUDA enabled in the config) will evaluate on Hydra due to a default dependency on Intel MKL.

@bcdarwin bcdarwin force-pushed the bcdarwin:skorch branch from d0ae583 to 581a80c May 9, 2020
@bcdarwin bcdarwin changed the title python3Packages.skorch: init at 0.7.0 python3Packages.skorch: init at 0.8.0 May 9, 2020
@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented May 9, 2020

@GrahamcOfBorg build python27Packages.skorch python37Packages.skorch python38Packages.skorch

@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented May 9, 2020

Rebased and build updated for Pytorch 1.4.

@bcdarwin bcdarwin requested a review from jonringer May 9, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented May 22, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/165

@bcdarwin bcdarwin force-pushed the bcdarwin:skorch branch from 581a80c to 710a487 May 26, 2020
@bcdarwin bcdarwin requested a review from bhipple May 26, 2020
@bhipple
Copy link
Contributor

@bhipple bhipple commented May 26, 2020

Result of nixpkgs-review pr 76997 1

2 packages built:
- python37Packages.skorch
- python38Packages.skorch
@bhipple bhipple merged commit cd9fb17 into NixOS:master May 26, 2020
16 checks passed
16 checks passed
python27Packages.skorch, python37Packages.skorch, python38Packages.skorch on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="710a487"; rev="710a48751a4db638626a2f6efd6c0f604e26cb7d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="710a487"; rev="710a48751a4db638626a2f6efd6c0f604e26cb7d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="710a487"; rev="710a48751a4db638626a2f6efd6c0f604e26cb7d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="710a487"; rev="710a48751a4db638626a2f6efd6c0f604e26cb7d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="710a487"; rev="710a48751a4db638626a2f6efd6c0f604e26cb7d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="710a487"; rev="710a48751a4db638626a2f6efd6c0f604e26cb7d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="710a487"; rev="710a48751a4db638626a2f6efd6c0f604e26cb7d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.skorch, python37Packages.skorch, python38Packages.skorch on x86_64-linux Success
Details
@bcdarwin bcdarwin deleted the bcdarwin:skorch branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.