Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile-sync-daemon: fix psd-overlay-helper paths #76998

Merged
merged 1 commit into from Apr 24, 2020

Conversation

@jflanglois
Copy link
Contributor

@jflanglois jflanglois commented Jan 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @prikhi

The installPhase for profile-sync-daemon does not properly replace
all binary invocations in psd-overlay-help. This fixes it.
@jflanglois jflanglois force-pushed the jflanglois:fix-psd-overlay-helper branch from 76bb5f3 to 0dd0d03 Jan 5, 2020
@jflanglois jflanglois requested a review from NickHu Feb 17, 2020
@NickHu
NickHu approved these changes Feb 17, 2020
@NickHu
Copy link
Contributor

@NickHu NickHu commented Feb 17, 2020

Could you please write up why this change was necessary, just for the record?

@jflanglois
Copy link
Contributor Author

@jflanglois jflanglois commented Feb 19, 2020

@NickHu Yes of course. Essentially one cannot use overlayfs mode Without this change because the helper binary will just fail without available sudo and stat commands.

@jflanglois
Copy link
Contributor Author

@jflanglois jflanglois commented Apr 16, 2020

@NickHu are we good to go merging this?

@NickHu
Copy link
Contributor

@NickHu NickHu commented Apr 16, 2020

@jflanglois I marked these changes as approved months ago, but I don't have the authority to merge. I'll ping someone in the IRC

@obadz obadz merged commit ea9b5c5 into NixOS:master Apr 24, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
profile-sync-daemon on aarch64-linux Success
Details
profile-sync-daemon on x86_64-linux Success
Details
@jflanglois jflanglois deleted the jflanglois:fix-psd-overlay-helper branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.