Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kicad: split version.nix & add update.sh #77003

Merged
merged 1 commit into from Jan 10, 2020
Merged

kicad: split version.nix & add update.sh #77003

merged 1 commit into from Jan 10, 2020

Conversation

@evils
Copy link
Contributor

@evils evils commented Jan 6, 2020

@gebner, a bit late, but i had fun making update.sh

i hope it's ok to include a fairly big script (at 6k it's the biggest file there)

Motivation for this change

current kicad-unstable is from last year, update missed the main PR merge
there's a lot of stuff to update, so i split off versions.nix and generate it with update.sh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from Kiwi Jan 6, 2020
@evils evils force-pushed the evils:kicad branch 3 times, most recently from 1390f7c to 86ab03c Jan 6, 2020
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Jan 8, 2020

Update-Automation is always appreciated. Especially for non-trivial software.

@evils evils changed the title kicad: split version.nix & add update.sh WIP kicad: split version.nix & add update.sh Jan 8, 2020
@evils evils force-pushed the evils:kicad branch from 86ab03c to 6e8667c Jan 8, 2020
@evils evils changed the title WIP kicad: split version.nix & add update.sh kicad: split version.nix & add update.sh Jan 8, 2020
@evils evils force-pushed the evils:kicad branch from 6e8667c to 1476040 Jan 8, 2020
update.sh generates version.nix
  by default only updates kicad-unstable
  several options (can be combined)
    all, update to latest tag and master
    clean, generate versions.sh from scratch
    commit, make a git commit
@evils evils force-pushed the evils:kicad branch from 1476040 to 2607c4b Jan 8, 2020
@Mic92 Mic92 merged commit 01d93cb into NixOS:master Jan 10, 2020
15 checks passed
15 checks passed
kicad on aarch64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kicad on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.