Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #77047

Merged
merged 52 commits into from Jan 14, 2020
Merged

Staging next #77047

merged 52 commits into from Jan 14, 2020

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jtojnar and others added 30 commits Dec 25, 2019
Introduced in 6449435, only Python 2 is supported and it does not seem to be used by anything.
Also remove no longer needed perl.
Nothing much seems to be using it and we do not want Python 2 in our closure.
It does not seem to be used by anything and we want to get rid of Python 2 from closure.
For some reason we depended on both.
It does not appear to be actually necessary – wafHook will add it.
Nothing seems to use the Python bindings anyway.
Static libraries are to be provided by the pkgsStatic.fmt package.
pkgsStatic.gtest already has CMAKE_BUILD_SHARED set to OFF.
pkgsStatic.glog already has CMAKE_BUILD_SHARED set to OFF.
pkgsStatic.double-conversion already has CMAKE_BUILD_SHARED set to OFF.
Apple no longer ships with it, so best to avoid forcing it into use.
Even when building for the simulator.
libtool is not really needed and it interferes with
updateAutotoolsGnuConfigScriptsHook. So remove it when
cross-compiling, but leave it in native to preserve hashes.
Update iOS for XCode 11
FRidh and others added 5 commits Jan 6, 2020
The nss rebuild isn't so small.
This is going to require more work.

This reverts commit 2dc4ab3.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 10, 2020

just curious? what made you back off python38?

major issues i could think of are aiohttp and one other ... I can't remember right now

@FRidh
Copy link
Member Author

@FRidh FRidh commented Jan 10, 2020

apparmor still partially fails and with it a lot of other packages, so that's why I reverted it for now

FRidh added 3 commits Jan 11, 2020
This updated only the version, not the hash.

#77372

This reverts commit 046c402.
@LnL7 LnL7 mentioned this pull request Jan 13, 2020
2 of 10 tasks complete
pkgs/development/libraries/glog/default.nix Outdated Show resolved Hide resolved
@FRidh FRidh merged commit 05a9658 into master Jan 14, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@tobim tobim mentioned this pull request Jan 14, 2020
0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.