Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bison2 #77051

Merged
merged 11 commits into from Jan 13, 2020
Merged

Remove bison2 #77051

merged 11 commits into from Jan 13, 2020

Conversation

@lblasc
Copy link
Contributor

@lblasc lblasc commented Jan 6, 2020

Motivation for this change

Bison is blocking #66528 it is better to remove it and skip funky patching. Last update was in 2012. Tested all packages which depended on it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@lblasc lblasc requested a review from ttuegel as a code owner Jan 6, 2020
@jtojnar jtojnar added this to To do in Picking up garbage via automation Jan 6, 2020
@jtojnar jtojnar moved this from To do to In progress in Picking up garbage Jan 6, 2020
@lblasc lblasc force-pushed the lblasc:bison2 branch from 829df3d to 95d4837 Jan 6, 2020
@lblasc
Copy link
Contributor Author

@lblasc lblasc commented Jan 6, 2020

@jtojnar thx for review, I've pushed changes you requested.

@Ma27
Ma27 approved these changes Jan 6, 2020
@Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 9, 2020

May I ask what's the status here? We could push this to staging and merge staging into the glibc branch, this would probably reduce the amount of broken packages there :)

@jtojnar
jtojnar approved these changes Jan 9, 2020
@lblasc lblasc changed the base branch from master to staging Jan 13, 2020
@lblasc lblasc force-pushed the lblasc:bison2 branch from 3dbab0b to 95c198a Jan 13, 2020
@lblasc
Copy link
Contributor Author

@lblasc lblasc commented Jan 13, 2020

I think it is safe to merge into staging. Branch is rebased and changed base to staging.

@jtojnar jtojnar merged commit eb90191 into NixOS:staging Jan 13, 2020
Picking up garbage automation moved this from In progress to Done Jan 13, 2020
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jan 13, 2020

Thanks.

@lblasc lblasc deleted the lblasc:bison2 branch Jan 13, 2020
@Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 13, 2020

Nice! @lblasc would you mind merging staging into the glibc branch and trigger a new evaluation tomorrow? :)

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 14, 2020
Remove bison2

(cherry picked from commit eb90191)
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.