Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: upstream no longer ships .el files for emacs #77071

Merged
merged 1 commit into from Feb 23, 2020

Conversation

@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Jan 6, 2020

Motivation for this change

git no longer ships emacs files, so there is no point having them. In fact, it makes things worse as running this will get emacs to very loudly complain due to the shipped .el artifacts all raising errors on eval.

(require 'git)

I haven't run nix-review as this change causes significant rebuilding.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@peterhoeg
Copy link
Member Author

@peterhoeg peterhoeg commented Jan 6, 2020

@peterhoeg
Copy link
Member Author

@peterhoeg peterhoeg commented Jan 13, 2020

@GrahamcOfBorg build git

@FRidh FRidh added this to WIP in Staging via automation Jan 15, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Jan 15, 2020
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 11, 2020

@GrahamcOfBorg build git

@peterhoeg
Copy link
Member Author

@peterhoeg peterhoeg commented Feb 23, 2020

I cannot see how the build failures on darwin and aarch64-linux could in any way be related to this change, so I am going ahead and merging this.

@peterhoeg peterhoeg merged commit 2ddfc45 into NixOS:staging Feb 23, 2020
16 checks passed
16 checks passed
git on aarch64-linux Failure
Details
git on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
git on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Needs review to Done Feb 23, 2020
@peterhoeg peterhoeg deleted the peterhoeg:git_emacs_files branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.