Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitAndTools.git-workspace: init at 0.4.1 #77082

Merged
merged 1 commit into from Jan 30, 2020

Conversation

@misuzu
Copy link
Contributor

@misuzu misuzu commented Jan 6, 2020

Motivation for this change

https://github.com/orf/git-workspace/releases/tag/v0.4.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

diff LGTM
executable shows usage

[5 built, 3 copied (143.6 MiB), 35.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77082
1 package built:
git-workspace
@teto
Copy link
Contributor

@teto teto commented Jan 9, 2020

I would rather see it in pkgs/applications/version-management/git-and-tools/default.nix

@misuzu misuzu force-pushed the misuzu:git-workspace-init branch from d22d1cf to 19a6cd3 Jan 9, 2020
@misuzu
Copy link
Contributor Author

@misuzu misuzu commented Jan 9, 2020

Moved to pkgs/applications/version-management/git-and-tools

@teto
Copy link
Contributor

@teto teto commented Jan 9, 2020

@GrahamcOfBorg build gitAndTools.git-workspace

@misuzu misuzu requested a review from worldofpeace Jan 28, 2020
{ stdenv, fetchFromGitHub, rustPlatform, Security }:
rustPlatform.buildRustPackage rec {
pname = "git-workspace";
version = "0.4.1";
src = fetchFromGitHub {
owner = "orf";
repo = pname;
rev = "v${version}";
sha256 = "01qxm00c5wqpy1clrvjr44v7cg4nqawaf5a6qnvvgswvis4kakzr";
};
cargoSha256 = "16rkmk888alfvq8nsggi26vck1c7ya0fa5j7gv219g5py4gw2n34";
verifyCargoDeps = true;
buildInputs = with stdenv; lib.optional isDarwin Security;
meta = with stdenv.lib; {
description = "Sync personal and work git repositories from multiple providers";
homepage = src.meta.homepage;
license = with licenses; [ mit ];
platforms = platforms.all;
maintainers = with maintainers; [ misuzu ];
};
}
Comment on lines 1 to 31

This comment has been minimized.

This comment has been minimized.

@misuzu

misuzu Jan 30, 2020
Author Contributor

This expression lacks any proper whitespace, see https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/pantheon/granite/default.nix

Will do.
Is there some kind of style guide? nixfmt says that everything is fine as it is now.

This comment has been minimized.

@worldofpeace

worldofpeace Jan 30, 2020
Member

Unfortunately there isn't. And I think nixfmt is more for formatting nix code and not nixpkgs, and in growing popularity https://github.com/nix-community/nixpkgs-fmt. But I can ask many many of the core body that expressions without whitespace separating attributes is pretty ugly.

I'm not sure if the coding conventions mentions this https://nixos.org/nixpkgs/manual/#chap-conventions, but a cursory look at nixpkgs hopefully reveals this (recent expressions).

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 30, 2020

@misuzu you need to change your commit message to start with the attr gitAndTools.git-workspace

@misuzu misuzu force-pushed the misuzu:git-workspace-init branch from 19a6cd3 to 9c2e01d Jan 30, 2020
@misuzu misuzu changed the title git-workspace: init at 0.4.1 gitAndTools.git-workspace: init at 0.4.1 Jan 30, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 30, 2020

Building it now, but it's probably good and will merge.

@misuzu misuzu force-pushed the misuzu:git-workspace-init branch from 9c2e01d to b81d1b1 Jan 30, 2020
@worldofpeace worldofpeace merged commit 183e706 into NixOS:master Jan 30, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 30, 2020

Thanks for contributing @misuzu

anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
gitAndTools.git-workspace: init at 0.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.