Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/activation: add types to options #77090

Closed
wants to merge 1 commit into from

Conversation

@lourkeur
Copy link
Contributor

lourkeur commented Jan 6, 2020

Motivation for this change

In response to #76184.

Things done

Create a type for the elements of nesting.clone and nesting.children and slap it on.
The new type doesn't do any validation. However, a type error will now be raised if the user forgets that both options expect lists.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS inapplicable
    • other Linux distributions inapplicable
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) inapplicable
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" inapplicable
  • Tested execution of all binary files (usually in ./result/bin/) inapplicable
  • Determined the impact on package closure size (by running nix path-info -S before and after) inapplicable
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lourkeur lourkeur force-pushed the lourkeur:fix_76184_nesting branch from c741bc7 to 7a00f4f Jan 6, 2020
@lourkeur
Copy link
Contributor Author

lourkeur commented Jun 30, 2020

Killed by the new specialisation mechanism

ec2d28e

@lourkeur lourkeur closed this Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.