Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms-sys: avoid leaking the build timestamp into the manpage #77096

Merged
merged 1 commit into from Jan 12, 2020

Conversation

@raboof
Copy link
Contributor

raboof commented Jan 6, 2020

Also proposed upstream as https://sourceforge.net/p/ms-sys/patches/8/

Motivation for this change

This makes the ms-sys deterministic, so building the same sources always produces the same bits.

Can be verified with nix-build '<nixpkgs>' -A ms-sys --check

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nh2 nh2 force-pushed the raboof:ms-sys-reproducibility branch from f621ce5 to b0ec8d6 Jan 12, 2020
@nh2

This comment has been minimized.

Copy link
Contributor

nh2 commented Jan 12, 2020

Added comment, merging.

@nh2 nh2 merged commit 2ddf7c0 into NixOS:master Jan 12, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Cloning project
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.