Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeKernelHeaders: expose via passthru, support kernel 5.3 and newer #77103

Closed

Conversation

@thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Jan 6, 2020

Motivation for this change

I want to provide newer kernel headers to a package that requires them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lostman

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 6, 2020

I agree it would be good to make this function public, however, we should avoid adding more functions to the top-level; it's really intended only for packages and package sets.

@thefloweringash
Copy link
Member Author

@thefloweringash thefloweringash commented Jan 6, 2020

Is there a recommended place to put functions like these?

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 6, 2020

Not really. You could add the function to its own passthru. You would then get linuxHeaders.makeLinuxHeaders.

@thefloweringash thefloweringash force-pushed the thefloweringash:make-kernel-headers branch from 1ff2c1a to 7adff80 Jan 6, 2020
@thefloweringash thefloweringash changed the title makeKernelHeaders: expose at top-level, support kernel 5.3 and newer makeKernelHeaders: expose via passthru, support kernel 5.3 and newer Jan 6, 2020
@orivej orivej mentioned this pull request Feb 1, 2020
5 of 10 tasks complete
@thefloweringash
Copy link
Member Author

@thefloweringash thefloweringash commented Feb 4, 2020

I think there may still be a reason to expose makeKernelHeaders when working with non-mainline features. However the features I wanted were merged around 5.0, so updating to 5.5 is sufficient. Going to close in favor of the update.

@thefloweringash thefloweringash deleted the thefloweringash:make-kernel-headers branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.