Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-miio: init at 0.4.8 #77113

Merged
merged 2 commits into from Jan 13, 2020
Merged

python-miio: init at 0.4.8 #77113

merged 2 commits into from Jan 13, 2020

Conversation

@flyfloh
Copy link
Contributor

@flyfloh flyfloh commented Jan 6, 2020

Motivation for this change

Homeassistant depends on this library, when connected to a Xiaomi Roborock vacuum cleaner.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@flyfloh flyfloh requested review from FRidh and jonringer as code owners Jan 6, 2020
Copy link
Contributor

@jonringer jonringer left a comment

you should avoid the first person when doing commits, it loses context reviewing subject lines:

flyfloh: add myself as maintainer

should be:

maintainers: add flyfloh
Florian added 2 commits Jan 6, 2020
Florian
Homeassitant uses this package to control Xiaomi Roborock vacuum
cleaners.
@flyfloh flyfloh force-pushed the flyfloh:python-miio branch from 6b3835f to 140cdea Jan 13, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM
executables seem to work
has tests 👍

[4 built, 6 copied (0.7 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77113
2 package built:
python37Packages.python-miio python38Packages.python-miio
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 13, 2020

@GrahamcOfBorg build python37Packages.python-miio python38Packages.python-miio

@jonringer jonringer merged commit c299740 into NixOS:master Jan 13, 2020
2 of 3 checks passed
2 of 3 checks passed
python37Packages.python-miio, python38Packages.python-miio on aarch64-linux
Details
python37Packages.python-miio, python38Packages.python-miio on x86_64-darwin Success
Details
python37Packages.python-miio, python38Packages.python-miio on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.