Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm9/clang: fix postInstall #77127

Closed
wants to merge 1 commit into from
Closed

Conversation

@stolyaroleh
Copy link

@stolyaroleh stolyaroleh commented Jan 6, 2020

Motivation for this change

#70364 moves lib/libclang-cpp.* to $lib, but does not update exported
CMake targets, which breaks lldb since it depends on clang.

Relevant: #70364 (review)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer

PR #70364 moves `lib/libclang-cpp.*` to `$lib`, but does not update exported
CMake targets, which breaks lldb.
@stolyaroleh stolyaroleh requested a review from matthewbauer as a code owner Jan 6, 2020
@xbreak
Copy link
Contributor

@xbreak xbreak commented Jan 6, 2020

I created an identical PR some time ago, here #76669.

@stolyaroleh
Copy link
Author

@stolyaroleh stolyaroleh commented Jan 6, 2020

@xbreak, sorry, I didn't see it (I was searching for issues related to lldb). Closing

@stolyaroleh stolyaroleh closed this Jan 6, 2020
@stolyaroleh stolyaroleh deleted the smarkets:clang9-fix-targets branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.