Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: fix errors and warning related to loaOf deprecation #77177

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Jan 7, 2020

Motivation for this change

While updating my nixpkgs I ran into various warnings and errors related to the loaOf deprecation in #63103. I fixed those here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@petabyteboy petabyteboy requested a review from peti as a code owner Jan 7, 2020
@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Jan 7, 2020

@petabyteboy petabyteboy force-pushed the petabyteboy:feature/loaof-deprecation branch from 635e990 to 2a31a6a Jan 7, 2020
Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM

@worldofpeace worldofpeace merged commit 04f6b5c into NixOS:master Jan 7, 2020
@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 7, 2020

Thank you

@bachp bachp mentioned this pull request Jan 8, 2020
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.