Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libev: Add statically linked `libev` to `pkgsStatic` #77180

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Jan 7, 2020

Motivation for this change

I have a use case for compiling a fully static binary with libev. I added this my project and it worked nicely.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @r-ryantm

anmonteiro added a commit to anmonteiro/nix-overlays that referenced this pull request Jan 7, 2020
while NixOS/nixpkgs#77180 isn't merged
@anmonteiro
Copy link
Member Author

@anmonteiro anmonteiro commented Jan 9, 2020

Could I get a review please? Tagging more folks from the commit history: @wkennington @fpletz @joachifm

@ryantm
Copy link
Member

@ryantm ryantm commented Jan 10, 2020

@GrahamcOfBorg build pkgsStatic.libev

@ryantm
ryantm approved these changes Jan 10, 2020
Copy link
Member

@ryantm ryantm left a comment

Well, it isn't building on Darwin, but this seems like a good enough start.

@ryantm ryantm merged commit 55adc49 into NixOS:master Jan 10, 2020
17 checks passed
17 checks passed
pkgsStatic.libev on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libev on aarch64-linux Success
Details
libev on x86_64-linux Success
Details
pkgsStatic.libev on aarch64-linux Success
Details
pkgsStatic.libev on x86_64-linux Success
Details
@anmonteiro
Copy link
Member Author

@anmonteiro anmonteiro commented Jan 10, 2020

Thanks. I haven't managed to cross compile on macOS yet. Last time I tried it failed to build the toolchain.

I could've done something wrong too. I'll try again soon.

@anmonteiro anmonteiro deleted the anmonteiro:anmonteiro/libev-static branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.