-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bash: enable PGRP_PIPE when building on recent kernels as well #77055 #77196
Conversation
5be2402
to
f0a7869
Compare
Hmm, I got the |
f0a7869
to
82f0f34
Compare
Also, this is a mass rebuild, it should go to the staging branch instead of master. |
82f0f34
to
7808e1b
Compare
7808e1b
to
6a98dfe
Compare
@GrahamcOfBorg build bash |
sorry that one was unintentional, github UI threw me off :( |
(targeted the staging branch and avoided requiring autoconf, so this is good for another review round) |
This still results in |
Motivation for this change
Hydra currently builds bash 4.4 correctly, but due to a limitation of the configure.ac it would incorrectly omit PGRP_PIPE when building on systems with more recent kernels. This has been fixed upstream in bash 5.0, and this PR pulls in that fix for 4.4 as well. See also #77055
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @matthewbauer