Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: enable PGRP_PIPE when building on recent kernels as well #77055 #77196

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@raboof
Copy link
Contributor

raboof commented Jan 7, 2020

Motivation for this change

Hydra currently builds bash 4.4 correctly, but due to a limitation of the configure.ac it would incorrectly omit PGRP_PIPE when building on systems with more recent kernels. This has been fixed upstream in bash 5.0, and this PR pulls in that fix for 4.4 as well. See also #77055

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer

pkgs/shells/bash/pgrp-pipe.patch Outdated Show resolved Hide resolved
@raboof raboof force-pushed the raboof:bash-issue-77055-enable-pgrp_pipe branch 2 times, most recently from 5be2402 to f0a7869 Jan 7, 2020
@ofborg ofborg bot requested a review from dtzWill Jan 7, 2020
@raboof

This comment has been minimized.

Copy link
Contributor Author

raboof commented Jan 7, 2020

Hmm, I got the autoconf: command not found error when trying to test this locally as well... thought it'd be something on my machine unrelated to the change in this PR - I guess I was wrong? Anyone see what's going on here?

@veprbl

This comment has been minimized.

@raboof raboof force-pushed the raboof:bash-issue-77055-enable-pgrp_pipe branch from f0a7869 to 82f0f34 Jan 7, 2020
pkgs/shells/bash/4.4.nix Outdated Show resolved Hide resolved
@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Jan 7, 2020

Also, this is a mass rebuild, it should go to the staging branch instead of master.

@raboof raboof force-pushed the raboof:bash-issue-77055-enable-pgrp_pipe branch from 82f0f34 to 7808e1b Jan 8, 2020
@raboof raboof changed the base branch from master to staging Jan 8, 2020
@raboof raboof force-pushed the raboof:bash-issue-77055-enable-pgrp_pipe branch from 7808e1b to 6a98dfe Jan 8, 2020
@veprbl veprbl added this to WIP in Staging via automation Jan 8, 2020
@veprbl veprbl moved this from WIP to Needs review in Staging Jan 8, 2020
@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Jan 8, 2020

@GrahamcOfBorg build bash

Staging automation moved this from Needs review to Ready Jan 8, 2020
@raboof raboof requested review from veprbl, matthewbauer and vcunat Jan 9, 2020
@raboof

This comment has been minimized.

Copy link
Contributor Author

raboof commented Jan 9, 2020

requested a review from matthewbauer now

sorry that one was unintentional, github UI threw me off :(

@raboof

This comment has been minimized.

Copy link
Contributor Author

raboof commented Jan 13, 2020

(targeted the staging branch and avoided requiring autoconf, so this is good for another review round)

@FRidh FRidh merged commit 996e11d into NixOS:staging Jan 15, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
bash on aarch64-linux Success
Details
bash on x86_64-darwin Success
Details
bash on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Ready to Done Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.