Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lorri: set version correctly #77198

wants to merge 1 commit into from


Copy link

@curiousleo curiousleo commented Jan 7, 2020

Motivation for this change

Currently the lorri version is always reported as "1" because the result of fetchFromGitHub does not have a revCount field. This is a problem when we're trying to support lorri users because we don't know which version they are on.

More context: target/lorri#219.

Before this change:

$ ~/Code/nixpkgs/result/bin/lorri info
lorri version: 1
Lorri Project Configuration

expression: <path>/shell.nix

After this change:

$ ~/Code/nixpkgs/result/bin/lorri info
lorri version: 310
Lorri Project Configuration

expression: <path>/shell.nix
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @

Copy link
Contributor Author

@curiousleo curiousleo commented Jan 7, 2020

We'll do this a different way. target/lorri#269 will document how we'll do releases and manage versions.

@curiousleo curiousleo closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.