Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jitterentropy: make man pages reproducible #77202

Merged

Conversation

@raboof
Copy link
Contributor

raboof commented Jan 7, 2020

Motivation for this change

Makes the package reproducible in the nix-build '<nixpkgs>' -A jitterentropy --check sense

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @JohnAZoidberg

@JohnAZoidberg

This comment has been minimized.

@raboof

This comment has been minimized.

Copy link
Contributor Author

raboof commented Jan 7, 2020

Cool, I didn't know about fetchpatch. I'm not sure it will work in this case though - I tried it with fetchurl at first, but that commit doesn't apply cleanly to 2.2.0

@JohnAZoidberg

This comment has been minimized.

Copy link
Member

JohnAZoidberg commented Jan 7, 2020

Oh, it's moved to a different line, well then it's okay.

@JohnAZoidberg JohnAZoidberg merged commit 5992086 into NixOS:master Jan 7, 2020
@raboof raboof deleted the raboof:jitterentropy-reproducible-manpages branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.