Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.dune_2: upgrade to 2.1.1 #77248

Closed
wants to merge 1 commit into from

Conversation

@anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Jan 7, 2020

Motivation for this change

Dune 2.1.0 has a pretty bad bug (which prevented it from being released to OPAM) related to linking to foreign (C) archives.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vbgl

@marsam
Copy link
Contributor

@marsam marsam commented Jan 8, 2020

addressed by #77199

@marsam marsam closed this Jan 8, 2020
@anmonteiro anmonteiro deleted the anmonteiro:anmonteiro/dune-2.1.1 branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.