Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-fhs-userenv: runCommand -> runCommandLocal #77253

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@bjornfor
Copy link
Contributor

bjornfor commented Jan 7, 2020

Motivation for this change

It's a trivial derivation, no need to build remotely (it's slower that
way).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

It's a trivial derivation, no need to build remotely (it's slower that
way).
@doronbehar

This comment has been minimized.

Copy link
Contributor

doronbehar commented Jan 8, 2020

So what's the purpose of this change? What's supposed to be with all of the derivations that use this function?

@bjornfor

This comment has been minimized.

Copy link
Contributor Author

bjornfor commented Jan 8, 2020

I don't know about other derivations, but from my quick testing, this is faster to build locally than remotely, even when the remote machine is on gigabit network and is more powerful than the local machine.

@danbst danbst merged commit d394c82 into NixOS:master Feb 14, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Feb 14, 2020

👍 thanks!

@bjornfor bjornfor deleted the bjornfor:build-fhs-user-env-locally branch Feb 14, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 14, 2020
It's a trivial derivation, no need to build remotely (it's slower that
way).

(cherry picked from commit d394c82)
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 15, 2020
This reverts commit b356ba2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.