Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pycm: init at 2.5 #77275

Merged
merged 1 commit into from Jan 9, 2020
Merged

python3Packages.pycm: init at 2.5 #77275

merged 1 commit into from Jan 9, 2020

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • [NA] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bcdarwin bcdarwin requested review from FRidh and jonringer as code owners Jan 7, 2020
pkgs/development/python-modules/pycm/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pycm/default.nix Outdated Show resolved Hide resolved
@bcdarwin bcdarwin force-pushed the bcdarwin:python3-pycm branch from 63885eb to acf107d Jan 7, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
has tests 👍

[4 built, 22 copied (50.0 MiB), 9.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77275
2 package were built:
python37Packages.pycm python38Packages.pycm
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 9, 2020

@GrahamcOfBorg build python37Packages.pycm python38Packages.pycm

@jonringer jonringer requested a review from FRidh Jan 9, 2020
@jonringer jonringer merged commit b4615c3 into NixOS:master Jan 9, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.pycm, python38Packages.pycm on aarch64-linux Success
Details
python37Packages.pycm, python38Packages.pycm on x86_64-darwin Success
Details
python37Packages.pycm, python38Packages.pycm on x86_64-linux Success
Details
@bcdarwin bcdarwin deleted the bcdarwin:python3-pycm branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.