Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.livelossplot: init at v0.5.0 #77281

Merged
merged 1 commit into from May 26, 2020

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • [NA] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bcdarwin bcdarwin requested review from FRidh and jonringer as code owners Jan 7, 2020
@bcdarwin bcdarwin changed the title python{2,3}Packages.livelossplot: init at unstable-2019-10-28 pythonPackages.livelossplot: init at unstable-2019-10-28 Jan 7, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:python-livelossplot branch from bc65637 to d5ef96e Jan 7, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:python-livelossplot branch from d5ef96e to 3b58f99 Feb 24, 2020
@bcdarwin bcdarwin changed the title pythonPackages.livelossplot: init at unstable-2019-10-28 pythonPackages.livelossplot: init at v.0.4.1 Feb 25, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:python-livelossplot branch from 3b58f99 to e0e88c0 Feb 25, 2020
Copy link
Contributor

@jonringer jonringer left a comment

can you update commit message to match PR title, still have it at unstable-...

git commit --amend

otherwise LGTM

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77281
3 package built:
python27Packages.livelossplot python37Packages.livelossplot python38Packages.livelossplot
@bcdarwin bcdarwin force-pushed the bcdarwin:python-livelossplot branch from e0e88c0 to 01c93d3 Feb 28, 2020
@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented Feb 28, 2020

Commit message rewritten.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 28, 2020

@GrahamcOfBorg build python27Packages.livelossplot python37Packages.livelossplot python38Packages.livelossplot

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commit LGTM

not sure what is up with "broken" noise

https://github.com/NixOS/nixpkgs/pull/77281
56 package marked as broken and skipped:
digitalbitbox gdata-sharp linuxPackages-libre.sch_cake linuxPackages.sch_cake linuxPackages_4_14.sch_cake linuxPackages_4_4.evdi linuxPackages_5_5.sch_cake linuxPackages_hardened.sch_cake linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.prl-tools linuxPackages_hardkernel_4_14.sch_cake linuxPackages_latest-libre.sch_cake linuxPackages_latest_hardened.sch_cake linuxPackages_latest_xen_dom0.sch_cake linuxPackages_latest_xen_dom0_hardened.sch_cake linuxPackages_testing_bcachefs.sch_cake linuxPackages_xen_dom0_hardened.sch_cake muslCross octave-jit php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages-unit.v8 php74Packages.pcs php74Packages.php_excel php74Packages.v8 python27Packages.caffe python27Packages.flitBuildHook python27Packages.habanero python27Packages.handout python27Packages.hass-nabucasa python27Packages.livereload python37Packages.nixpart python37Packages.notify python37Packages.pyblock python38Packages.libselinux python38Packages.nixpart python38Packages.poezio python38Packages.pyblock torchPackages.lua-cjson torchPackages.luaffifb

3 package built:
python27Packages.livelossplot python37Packages.livelossplot python38Packages.livelossplot
@bcdarwin bcdarwin force-pushed the bcdarwin:python-livelossplot branch 2 times, most recently from 7819177 to 054c6cb May 9, 2020
@bcdarwin bcdarwin changed the title pythonPackages.livelossplot: init at v.0.4.1 pythonPackages.livelossplot: init at v0.5.0 May 9, 2020
@bcdarwin bcdarwin changed the title pythonPackages.livelossplot: init at v0.5.0 python3Packages.livelossplot: init at v0.5.0 May 9, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:python-livelossplot branch from 054c6cb to 37d3be7 May 9, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:python-livelossplot branch from 37d3be7 to 43d6898 May 9, 2020
@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented May 9, 2020

Rebased, updated, and tests fixed.

@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented May 9, 2020

@GrahamcOfBorg build python27Packages.livelossplot python37Packages.livelossplot python38Packages.livelossplot

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented May 22, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/165

@bhipple
Copy link
Contributor

@bhipple bhipple commented May 26, 2020

Result of nixpkgs-review pr 77281 1

2 packages built:
- python37Packages.livelossplot
- python38Packages.livelossplot
@bhipple bhipple merged commit 77eb712 into NixOS:master May 26, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="43d6898"; rev="43d6898ea2dd234c6626b459270d564cda551f41"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="43d6898"; rev="43d6898ea2dd234c6626b459270d564cda551f41"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="43d6898"; rev="43d6898ea2dd234c6626b459270d564cda551f41"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="43d6898"; rev="43d6898ea2dd234c6626b459270d564cda551f41"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="43d6898"; rev="43d6898ea2dd234c6626b459270d564cda551f41"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="43d6898"; rev="43d6898ea2dd234c6626b459270d564cda551f41"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="43d6898"; rev="43d6898ea2dd234c6626b459270d564cda551f41"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.livelossplot, python37Packages.livelossplot, python38Packages.livelossplot on aarch64-linux Success
Details
python27Packages.livelossplot, python37Packages.livelossplot, python38Packages.livelossplot on x86_64-linux Success
Details
@bcdarwin bcdarwin deleted the bcdarwin:python-livelossplot branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.