Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.crc32c: init at 2.0 #77283

Merged
merged 1 commit into from Jan 8, 2020
Merged

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • [NA] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [NA] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@jonringer jonringer left a comment

the commit message should still point to an installable:

version of python doesn't matter unless that version is unsupported.

pythonPackages.crc32c: init at 2.0

I can't remember the reason, but generally aligning the equal signs is not preferred. I think it was for automated scripts which may not preserve white-space. But can't remmber exactly

I guess 2-3 nits, otherwise LGTM

https://github.com/NixOS/nixpkgs/pull/77283
3 package were built:
python27Packages.crc32c python37Packages.crc32c python38Packages.crc32c
pkgs/development/python-modules/crc32c/default.nix Outdated Show resolved Hide resolved
@bcdarwin bcdarwin force-pushed the bcdarwin:python-crc32c branch 3 times, most recently from bcf90df to d39d14d Jan 7, 2020
@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented Jan 7, 2020

Everything resolved.

@bcdarwin bcdarwin changed the title python{2,3}Packages.crc32c: init at 2.0 pythonPackages.crc32c: init at 2.0 Jan 7, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:python-crc32c branch from d39d14d to ed05f17 Jan 7, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
has tests 👍

https://github.com/NixOS/nixpkgs/pull/77283
3 package were built:
python27Packages.crc32c python37Packages.crc32c python38Packages.crc32c
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 8, 2020

@GrahamcOfBorg build python27Packages.crc32c python37Packages.crc32c python38Packages.crc32c

@jonringer jonringer merged commit 81179a4 into NixOS:master Jan 8, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.crc32c, python37Packages.crc32c, python38Packages.crc32c on aarch64-linux Success
Details
python27Packages.crc32c, python37Packages.crc32c, python38Packages.crc32c on x86_64-darwin Success
Details
python27Packages.crc32c, python37Packages.crc32c, python38Packages.crc32c on x86_64-linux Success
Details
@bcdarwin bcdarwin deleted the bcdarwin:python-crc32c branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.