Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.aws-adfs: add missing requests-kerberos dependency #77287

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 7, 2020

Motivation for this change

noticed it was broken reviewing #77254

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

https://github.com/NixOS/nixpkgs/pull/77287
2 package were built:
aws-adfs python38Packages.aws-adfs
@jonringer jonringer requested a review from FRidh as a code owner Jan 7, 2020
@ofborg ofborg bot added the 6.topic: python label Jan 7, 2020
@ofborg ofborg bot requested a review from bhipple Jan 7, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Jan 7, 2020

@GrahamcOfBorg build aws-adfs python38Packages.aws-adfs

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Jan 8, 2020

darwin failure not related to PR

@jonringer jonringer merged commit acddd86 into NixOS:master Jan 8, 2020
16 checks passed
16 checks passed
aws-adfs, python38Packages.aws-adfs on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
aws-adfs, python38Packages.aws-adfs on aarch64-linux Success
Details
aws-adfs, python38Packages.aws-adfs on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:fix-aws-adfs branch Jan 8, 2020
@bhipple
Copy link
Contributor

@bhipple bhipple commented Jan 8, 2020

Nice, thanks @jonringer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.