Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorio: update all versions to 0.17.79 #77288

Closed
wants to merge 1 commit into from
Closed

Conversation

@artemist
Copy link
Member

@artemist artemist commented Jan 8, 2020

Motivation for this change

The current version of factorio is quite out of date, meaning that servers run on NixOS will not work with current clients.

Things done

This updates all factorio packages, including factorio, factorio-experimental, factorio-demo, factorio-headless, and factorio-headless-experimental, to the latest version, 0.17.79. Note that as both alpha and experimental are the same version, and will thus output the same package with the same hash.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @elitak @Baughn

@artemist
Copy link
Member Author

@artemist artemist commented Jan 8, 2020

@GrahamcOfBorg build factorio-headless factorio-demo

Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM, didn't test though. I have no reservation about the commit message not being $old_version -> $new_version, this is just fine.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 8, 2020

The current version of factorio is quite out of date, meaning that servers run on NixOS will not work with current clients.

Is this being out of date an issue for users of 19.09?

@artemist
Copy link
Member Author

@artemist artemist commented Jan 8, 2020

I don't think it's enough of an issue to backport. People who are running factorio servers on NixOS, especially stable, probably override the package manually

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 11, 2020

Hmm, this is essentially a duplicate #73165

@artemist
Copy link
Member Author

@artemist artemist commented Jan 11, 2020

@worldofpeace worldofpeace mentioned this pull request Jan 11, 2020
2 of 10 tasks complete
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 11, 2020

Oh, oops! I didn't notice that existed. If you'd prefer to merge that one, I can close this one.

-- Artemis Tosini me@artem.ist Am Sa, 11. Jan 2020, um 12:53, schrieb worldofpeace:
Hmm, this is essentially a duplicate #73165 <#73165> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#77288?email_source=notifications&email_token=AAJLPDQCGCRMGW6DM5O2TJTQ5G6L5A5CNFSM4KEA3MX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWBKGQ#issuecomment-573314330>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJLPDXD4C37DQARUQGR3QTQ5G6L5ANCNFSM4KEA3MXQ.

Thanks anyways, I considered it extra free QA 👍
I've merged the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.