Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] firefox: 71.0 -> 72.0 #77292

Merged
merged 9 commits into from Jan 8, 2020
Merged

[19.09] firefox: 71.0 -> 72.0 #77292

merged 9 commits into from Jan 8, 2020

Conversation

@andir
Copy link
Member

@andir andir commented Jan 8, 2020

Motivation for this change

This bumps firefox 71.0 to 72.0. It also removes the patch @fpletz added with 71.0 with the upstream version of that patch that supposedly fixes more issue with e.g. riot.im.

Call for testers: @maralorn @fpletz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers
andir added 8 commits Jan 4, 2020
@andir
Copy link
Member Author

@andir andir commented Jan 8, 2020

I am kinda unhappy about the use of dontFixLibtool here... I think it would be better to fixup the cargo hashsum check by putting back the unmodified file.

@taku0
Copy link
Contributor

@taku0 taku0 commented Jan 8, 2020

Also firefox-esr should be updated (68.3.0esr -> 68.4.0esr).

@maralorn
Copy link
Contributor

@maralorn maralorn commented Jan 8, 2020

I have compiled this (e.g. firefox 72) successfully and tried it out it bit. I don‘t see any problems. riot.im works.

(cherry picked from commit 2ad59bd)
@andir
Copy link
Member Author

@andir andir commented Jan 8, 2020

Added the -esr-68 update as well build is still running against this branch.

@andir andir merged commit db5273c into NixOS:release-19.09 Jan 8, 2020
15 of 16 checks passed
15 of 16 checks passed
nspr, nss_3_48, sqlite on aarch64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nspr, nss_3_48, sqlite on x86_64-darwin Success
Details
nspr, nss_3_48, sqlite on x86_64-linux Success
Details
@andir andir deleted the andir:19.09-firefox72 branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.