Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsyslog: include libmaxminddb #77300

Merged
merged 2 commits into from Jan 24, 2020
Merged

rsyslog: include libmaxminddb #77300

merged 2 commits into from Jan 24, 2020

Conversation

@basilgood
Copy link
Contributor

@basilgood basilgood commented Jan 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Contributor

@aanderse aanderse commented Jan 9, 2020

@basilgood you should add libmaxminddb to buildInputs.

@basilgood basilgood force-pushed the plumelo:rsyslog branch 2 times, most recently from 3158f06 to 3b7a20e Jan 9, 2020
@aanderse aanderse requested review from NeQuissimus and fpletz Jan 9, 2020
@NeQuissimus NeQuissimus removed their request for review Jan 9, 2020
@aanderse
Copy link
Contributor

@aanderse aanderse commented Jan 18, 2020

@basilgood I was hoping someone who has done some work on this package before would review but that doesn't seem to be the case. I've looked into the docs in a bit more detail and gone through the package in nixpkgs some more so I guess we're good to go, right after you update the declaration of rsyslog-light in all-packages.nix.

Thanks!

@megheaiulian megheaiulian force-pushed the plumelo:rsyslog branch from 3b7a20e to be692c4 Jan 23, 2020
@megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Jan 23, 2020

@aanderse Please have a look again.

@aanderse
Copy link
Contributor

@aanderse aanderse commented Jan 24, 2020

Thanks @megheaiulian and @basilgood. I don't use any libmaxminddb stuff with rsyslog so I'm not really in a position to test this. It is a pretty simple change and after reading through the documentation I'm inclined to think I can just click merge, but I'd like to at least hear one person say they've tested this and it works as expected. Have either of you tested this? Anyone?

@megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Jan 24, 2020

We're currently running this change on a server where rsyslog adds geoip info to logs.

@aanderse aanderse merged commit ddbb15d into NixOS:master Jan 24, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rsyslog, rsyslog-light on aarch64-linux Success
Details
rsyslog, rsyslog-light on x86_64-linux Success
Details
@megheaiulian megheaiulian deleted the plumelo:rsyslog branch Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.