Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port elk initdb kafka #77303

Merged
merged 5 commits into from Jan 10, 2020
Merged

Port elk initdb kafka #77303

merged 5 commits into from Jan 10, 2020

Conversation

@tfc
Copy link
Contributor

@tfc tfc commented Jan 8, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @flokli

@tfc
Copy link
Contributor Author

@tfc tfc commented Jan 8, 2020

@GrahamcOfBorg test initdb elk kafka

@flokli
Copy link
Contributor

@flokli flokli commented Jan 9, 2020

initdb is missing from all-tests.nix. Also, it might make sense to just include this with the other postgresql tests.

@tfc
Copy link
Contributor Author

@tfc tfc commented Jan 9, 2020

Also, it might make sense to just include this with the other postgresql tests.

Do you mean including in the sense of grouping it into another existing postgres test file or giving it a similar name like the others?

@flokli
Copy link
Contributor

@flokli flokli commented Jan 9, 2020

Whatever you feel to be more appropriate. Personally, I'd say it's small enough to just group it into an existing test.

@tfc
Copy link
Contributor Author

@tfc tfc commented Jan 9, 2020

Whatever you feel to be more appropriate. Personally, I'd say it's small enough to just group it into an existing test.

Oh, you mean actually putting the code into the test script of an existing test. That makes sense, too. I am on it.

@tfc tfc requested a review from thoughtpolice as a code owner Jan 9, 2020
@tfc
Copy link
Contributor Author

@tfc tfc commented Jan 9, 2020

@flokli done, please have a look.

@tfc
Copy link
Contributor Author

@tfc tfc commented Jan 9, 2020

@GrahamcOfBorg test postgres

@tfc
Copy link
Contributor Author

@tfc tfc commented Jan 9, 2020

@GrahamcOfBorg test postgresql

@flokli
flokli approved these changes Jan 10, 2020
@flokli flokli merged commit 47e0ce7 into NixOS:master Jan 10, 2020
16 checks passed
16 checks passed
tests.postgres on aarch64-linux No attempt
Details
tests.postgres on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.postgresql on aarch64-linux Success
Details
tests.postgresql on x86_64-linux Success
Details
@tfc tfc deleted the tfc:port-elk-initdb-kafka branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.