Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskell: 1.7.3 -> 1.9.3 #77315

Merged
merged 3 commits into from Jul 22, 2020
Merged

taskell: 1.7.3 -> 1.9.3 #77315

merged 3 commits into from Jul 22, 2020

Conversation

@matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Jan 8, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

diff LGTM
executable works

[3 built, 78 copied (244.0 MiB), 16.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77315
1 package built:
taskell
@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Jan 8, 2020

LGTM! Matches what I put together and have been using, too. :)

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Jan 8, 2020

Bummer re:darwin failure (fails to build haskell tz, see builder logs), as taskell previously was building successfully: https://hydra.nixos.org/build/109464110 . Don't know how important this is to Darwin folks but seemed worth mentioning, at least :).

@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:update-taskell branch from 4a6b326 to 977eb09 Feb 6, 2020
@matthiasbeyer matthiasbeyer changed the title taskell: 1.7.3 -> 1.9.0 taskell: 1.7.3 -> 1.9.2 Feb 6, 2020
@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:update-taskell branch from 977eb09 to 813ed12 Feb 24, 2020
@matthiasbeyer matthiasbeyer changed the title taskell: 1.7.3 -> 1.9.2 taskell: 1.7.3 -> 1.9.3 Feb 24, 2020
@matthiasbeyer
Copy link
Contributor Author

@matthiasbeyer matthiasbeyer commented Feb 24, 2020

How about merging this PR?

@matthiasbeyer matthiasbeyer requested review from doronbehar and Br1ght0ne Feb 24, 2020
@Br1ght0ne
Copy link
Contributor

@Br1ght0ne Br1ght0ne commented Feb 24, 2020

@GrahamcOfBorg build taskell

@alyssais
Copy link
Member

@alyssais alyssais commented Mar 14, 2020

Should either be fixed or marked as broken on or incompatible with Darwin and aarch64.

@matthiasbeyer
Copy link
Contributor Author

@matthiasbeyer matthiasbeyer commented Apr 2, 2020

Should either be fixed or marked as broken on or incompatible with Darwin and aarch64.

How to do that?

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Apr 2, 2020

platforms = [ "x86_64-linux" ];

@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:update-taskell branch from 813ed12 to 3489d7a Apr 2, 2020
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

diff LGTM

[3 built, 266 copied (3297.4 MiB), 222.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77315
1 package built:
taskell

$ nix-shell /home/brightone/.cache/nixpkgs-review/pr-77315/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-77315]$ taskell test
Create /home/brightone/.cache/nixpkgs-review/pr-77315/test? (Y/n):
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Contributor Author

@matthiasbeyer matthiasbeyer commented May 20, 2020

Please merge this.

1 similar comment
@matthiasbeyer
Copy link
Contributor Author

@matthiasbeyer matthiasbeyer commented Jul 21, 2020

Please merge this.

@Br1ght0ne Br1ght0ne merged commit 3ed1f3b into NixOS:master Jul 22, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="58e83da"; rev="58e83da9e329bb5866ae0fc092bfa5e412d97965"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="58e83da"; rev="58e83da9e329bb5866ae0fc092bfa5e412d97965"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="58e83da"; rev="58e83da9e329bb5866ae0fc092bfa5e412d97965"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="58e83da"; rev="58e83da9e329bb5866ae0fc092bfa5e412d97965"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="58e83da"; rev="58e83da9e329bb5866ae0fc092bfa5e412d97965"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="58e83da"; rev="58e83da9e329bb5866ae0fc092bfa5e412d97965"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="58e83da"; rev="58e83da9e329bb5866ae0fc092bfa5e412d97965"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@matthiasbeyer matthiasbeyer deleted the matthiasbeyer:update-taskell branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.