Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Add support for installing Python eggs #77319

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@adisbladis
Copy link
Member

adisbladis commented Jan 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andir

@adisbladis adisbladis requested a review from FRidh Jan 8, 2020
@adisbladis adisbladis requested a review from jonringer as a code owner Jan 8, 2020
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Jan 8, 2020

woah, egg's, that's prehistoric? Do we really need it? Code looks good, nothing wrong with that, it just feels strange adding support for something that's completely out.

@adisbladis

This comment has been minimized.

Copy link
Member Author

adisbladis commented Jan 8, 2020

@FRidh I added it for poetry2nix to automatically do the right thing when it encounters an egg. There are legit cases where an egg might be the only option.

Hopefully not something we'd have to use more than occasionally :)

@FRidh
FRidh approved these changes Jan 8, 2020
Copy link
Member

FRidh left a comment

Good enough reason.

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Jan 8, 2020

Ah wait, the manual needs to include these. THere's a list of hooks.

@adisbladis adisbladis force-pushed the adisbladis:python-eggs branch from 609c869 to 2d6f1ff Jan 8, 2020
@adisbladis

This comment has been minimized.

Copy link
Member Author

adisbladis commented Jan 8, 2020

I've added docs :)

@adisbladis adisbladis merged commit dd6970c into NixOS:master Jan 8, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python on aarch64-linux Success
Details
python on x86_64-darwin Success
Details
python on x86_64-linux Success
Details
@adisbladis adisbladis mentioned this pull request Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.