Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustPackages: recurse in to package sets so Hydra builds clippy #77320

Closed
wants to merge 1 commit into from

Conversation

@grahamc
Copy link
Member

grahamc commented Jan 8, 2020

Motivation for this change

Hydra doesn't build clippy, but it probably should?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@grahamc grahamc requested review from LnL7 and Mic92 as code owners Jan 8, 2020
@ofborg ofborg bot added the 6.topic: rust label Jan 8, 2020
@LnL7
LnL7 approved these changes Jan 8, 2020
Copy link
Member

LnL7 left a comment

This isn't a full package set but just a couple of namespaced tools so recursing (including nix-env -q) should be fine.

@grahamc

This comment has been minimized.

Copy link
Member Author

grahamc commented Jan 8, 2020

@grahamc grahamc mentioned this pull request Jan 8, 2020
2 of 10 tasks complete
@Ma27
Ma27 approved these changes Jan 9, 2020
@grahamc

This comment has been minimized.

Copy link
Member Author

grahamc commented Jan 9, 2020

Not sure why it breaks evaluation, but also not going to look further :x.

@grahamc grahamc closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.